From 73fdfe1795b2c1be4914f13bf973c83beac5050b Mon Sep 17 00:00:00 2001
From: ilotterytea <iltsu@alright.party>
Date: Tue, 22 Apr 2025 15:00:57 +0500
Subject: upd: unnecessary check in search requests

---
 public/emotes/index.php | 22 ++++++----------------
 1 file changed, 6 insertions(+), 16 deletions(-)

(limited to 'public/emotes/index.php')

diff --git a/public/emotes/index.php b/public/emotes/index.php
index 4cddc47..b074e0a 100644
--- a/public/emotes/index.php
+++ b/public/emotes/index.php
@@ -12,7 +12,7 @@ $db = new PDO(DB_URL, DB_USER, DB_PASS);
 
 function display_list_emotes(PDO &$db, int $page, int $limit): array
 {
-    $search = $_GET["q"] ?? "";
+    $search = "%" . ($_GET["q"] ?? "") . "%";
     $user_id = $_SESSION["user_id"] ?? "-1";
     $offset = $page * $limit;
     $stmt = $db->prepare("SELECT e.*,
@@ -22,25 +22,15 @@ function display_list_emotes(PDO &$db, int $page, int $limit): array
         INNER JOIN emote_sets es ON es.id = ec.emote_set_id
         WHERE ec.emote_id = e.id AND es.owner_id = ?
     ) THEN 1 ELSE 0 END AS is_in_user_set
-    FROM emotes e " .
-        (($search != "") ? "WHERE e.code LIKE ?" : "")
-        .
-        "
+    FROM emotes e WHERE e.code LIKE ?
     ORDER BY e.created_at ASC
     LIMIT ? OFFSET ?
     ");
 
-    if ($search == "") {
-        $stmt->bindParam(1, $user_id, PDO::PARAM_INT);
-        $stmt->bindParam(2, $limit, PDO::PARAM_INT);
-        $stmt->bindParam(3, $offset, PDO::PARAM_INT);
-    } else {
-        $search = "%$search%";
-        $stmt->bindParam(1, $user_id, PDO::PARAM_INT);
-        $stmt->bindParam(2, $search, PDO::PARAM_STR);
-        $stmt->bindParam(3, $limit, PDO::PARAM_INT);
-        $stmt->bindParam(4, $offset, PDO::PARAM_INT);
-    }
+    $stmt->bindParam(1, $user_id, PDO::PARAM_INT);
+    $stmt->bindParam(2, $search, PDO::PARAM_STR);
+    $stmt->bindParam(3, $limit, PDO::PARAM_INT);
+    $stmt->bindParam(4, $offset, PDO::PARAM_INT);
 
     $stmt->execute();
 
-- 
cgit v1.2.3